ROX-34629: Interpret CVE Created Time on create report from filters#20447
Open
pedrottimark wants to merge 1 commit intomasterfrom
Open
ROX-34629: Interpret CVE Created Time on create report from filters#20447pedrottimark wants to merge 1 commit intomasterfrom
pedrottimark wants to merge 1 commit intomasterfrom
Conversation
Contributor
🚀 Build Images ReadyImages are ready for commit 4f78a5a. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-913-g4f78a5a7d6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Objective
Provide equivalent filter for schduled reports as view-based reports
Problem
Inconsistent time filter:
Results search filter
'CVE Created Time'also known as First discovered table heading means in entire system and has relations<=>Report configuration option
sinceStartDatemeans in image and has relation after.Although search filter seems unlikely to help directly, if it has After relation, then is seems helpful to initialize
sinceStartDateproperty on.Analysis
ImageVulnerabilityReportWizardPage.tsx file already filters the search filter (pardon pun).
resourceScope.entityScope.rulesgetEntityScopeRulesFromSearchFilterForClusterNamespaceDeploymentfunctionquerygetSearchFilterWithoutEntityScopefunctionUnlike 2 existing functions are in entityScopeRules.ts file, this is specific to vulnerabioities.
Date format:
'CVE Created Time'hasmm/dd/yyyysinceStartDatehasyyyy=mm-ddThis edge case was last blocker for Create scheduled report action.
Solution
Edit ImageVulnerabilityReportWizardPage.ts file.
Because both negative and positive side to the coin, include inline.
Even though, it seens not specific to image vulnerability report configurations.
searchFilterWithoutEntityScopebeforegetRequestQueryStringForSearchFiltercall.>then assignvulnReportFilters.sinceStartDateproperty.Edit CreateReportDropdown.tsx file.
featureFlagDependencyproperty.Edit featureFlag.ts file.
Delete last occurrence of
'ROX_VULNERABILITY_REPORTS_ENHANCED_FILTERING'in ui code.What we need to do, although my misunderstanding that central code does use feature flag.
Residue
User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.npm run startin ui/apps/platform folder with staging demo as central.Manual testing
Visit /main/vulnerabilities/platform select search filters, click Create report click Create scheduled report

And then advance to Filters step of wizard
Without changes, see All time and presence of label for inconsistency search criterion

Note: 1/1/2026 but other pictures have 1/2/2026 because I needed make sure about
ddandmmfor code.With changes, see Custom start date and absence of label

Repeat with On as relationship.
Apparent bug (probably my bad from CISA KEV effort) that compound search filter ignores it.
Repeat with Before as relationship.
With changes, see All time and absence of label