feat(sfs): extend snapshot create with --snaplock-retention-hours#1402
Open
cgoetz-inovex wants to merge 2 commits intomainfrom
Open
feat(sfs): extend snapshot create with --snaplock-retention-hours#1402cgoetz-inovex wants to merge 2 commits intomainfrom
cgoetz-inovex wants to merge 2 commits intomainfrom
Conversation
cgoetz-inovex
commented
May 8, 2026
| Comment: *sfs.NewNullableString(model.Comment), | ||
| Name: utils.Ptr(model.Name), | ||
| Comment: *sfs.NewNullableString(model.Comment), | ||
| SnaplockRetentionHours: *sfs.NewNullableInt32(model.SnaplockRetentionHours), |
Contributor
Author
There was a problem hiding this comment.
in the spec this is defined as integer or null <uint32>. The generator uses an int32 here, which does not cover all values of an uint32. Here it does not matter, but should we investigate this further?
Member
There was a problem hiding this comment.
Wait, but isn't it already of type NullableInt32?
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STACKITCLI-399
Description
relates to #1234
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)