Replace assert with direct call for table validation#651
Merged
Conversation
`assert _ensure_table_and_layer_exist_in_sdata(...)` is stripped under `python -O` / `PYTHONOPTIMIZE=1`, silently bypassing user-input validation. Call the function unconditionally so it raises `ValueError` regardless of interpreter optimization level. Fixes #616
timtreis
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
=======================================
Coverage 76.86% 76.86%
=======================================
Files 11 11
Lines 3277 3277
Branches 774 774
=======================================
Hits 2519 2519
Misses 457 457
Partials 301 301
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert _ensure_table_and_layer_exist_in_sdata(...)with a direct call in_type_check_params(src/spatialdata_plot/pl/utils.py).assertis stripped underpython -O/PYTHONOPTIMIZE=1, silently bypassing user-input validation. The function already raisesValueErroron failure; its return value is unused, only the side effect matters.Fixes #616.