GH-149501: Fix compilation warning for _YIELD_VALUE#149502
Open
sergey-miryanov wants to merge 3 commits intopython:mainfrom
Open
GH-149501: Fix compilation warning for _YIELD_VALUE#149502sergey-miryanov wants to merge 3 commits intopython:mainfrom
sergey-miryanov wants to merge 3 commits intopython:mainfrom
Conversation
Contributor
Author
|
cc @vstinner as an author of the change |
sergey-miryanov
force-pushed
the
bug/149501-fix-msvc-warning
branch
from
f3eadda to
0cb3e7d
Compare
Member
|
Would it be possible to change i type to size_t or Py_ssize_t instead? |
sergey-miryanov
commented
May 8, 2026
| PyAPI_FUNC(_Py_CODEUNIT) _Py_GetBaseCodeUnit(PyCodeObject *code, int offset); | ||
| PyAPI_FUNC(_Py_CODEUNIT) _Py_GetBaseCodeUnit(PyCodeObject *code, Py_ssize_t offset); | ||
|
|
||
| extern int _PyInstruction_GetLength(PyCodeObject *code, int offset); |
Contributor
Author
There was a problem hiding this comment.
Should we change the type here as well for consistency?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix warning for MSVC