Skip to content

test: remove usage of inherits#63178

Open
AugustinMauroy wants to merge 3 commits intonodejs:mainfrom
AugustinMauroy:update-test
Open

test: remove usage of inherits#63178
AugustinMauroy wants to merge 3 commits intonodejs:mainfrom
AugustinMauroy:update-test

Conversation

@AugustinMauroy
Copy link
Copy Markdown
Member

Description

Remove useage of utils.intherits on test. this legacy api is still tested test-util-inherits.js

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 7, 2026
@juanarbol
Copy link
Copy Markdown
Member

Could you please add the Signed-off-by trailer as the linter wants? I do it by using the -s option to the git commit command.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.03%. Comparing base (4f44c6f) to head (dd7f554).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63178      +/-   ##
==========================================
- Coverage   90.04%   90.03%   -0.02%     
==========================================
  Files         713      713              
  Lines      224645   224699      +54     
  Branches    42448    42480      +32     
==========================================
+ Hits       202288   202297       +9     
- Misses      14167    14183      +16     
- Partials     8190     8219      +29     

see 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
@AugustinMauroy
Copy link
Copy Markdown
Member Author

Could you please add the Signed-off-by trailer as the linter wants? I do it by using the -s option to the git commit command.

I ran git commit --amend -s and poof it's seem working. but strange thing is that gh desktop not automatically do it ...

Comment on lines -7 to -8
// Inherits from EE without a call to the
// parent constructor.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that PR removes this check, seems important

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wich check are you talking about ?

Copy link
Copy Markdown
Contributor

@aduh95 aduh95 May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment I've highlighted: having an object that inherits from EE without a call to the EE constructor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants