Skip to content

doc: deprecation add more codemod#63175

Open
AugustinMauroy wants to merge 1 commit intonodejs:mainfrom
AugustinMauroy:add-more-codemod
Open

doc: deprecation add more codemod#63175
AugustinMauroy wants to merge 1 commit intonodejs:mainfrom
AugustinMauroy:add-more-codemod

Conversation

@AugustinMauroy
Copy link
Copy Markdown
Member

Description

Adding new codemod since last time to the deprecation page.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/userland-migrations

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels May 7, 2026
@AugustinMauroy AugustinMauroy changed the title doc: add more codemod to deprecation page doc: deprecation add more codemod May 7, 2026
Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
Comment thread doc/api/deprecations.md
The `tls.createSecurePair()` API was deprecated in documentation in Node.js
0.11.3. Users should use `tls.Socket` instead.

An automated migration is available ([source](https://github.com/nodejs/userland-migrations/tree/main/recipes/tls-create-secure-pair-to-tls-socket)):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create reference style links at the bottom of the page, and link them here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't thinks we need that. because it's use one time and it's not supposed to changed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's precedence for that:

An automated migration is available ([source](https://github.com/nodejs/userland-migrations/tree/main/recipes/tmpdir-to-tmpdir)):
```bash
npx codemod@latest @nodejs/tmpDir-to-tmpdir
```

@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented May 8, 2026

The commit message doesn't follow our guideline, the first word after the subsystem (deprecation) is not a verb in imperative form.

@AugustinMauroy
Copy link
Copy Markdown
Member Author

The commit message doesn't follow our guideline, the first word after the subsystem (deprecation) is not a verb in imperative form.

oh my bad. I think there are change since my last pr because sing-off wasn't required and other thing.

so something like "doc: update deprecation with more codemod" ?

@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented May 8, 2026

oh my bad. I think there are change since my last pr because sing-off wasn't required and other thing.

The imperative verb requirement was added in a4d396d :p

so something like "doc: update deprecation with more codemod" ?

doc: add more codemod references in `deprecations.md`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants