deps: add missing static linking targets for libffi#63168
Open
ShogunPanda wants to merge 3 commits intonodejs:mainfrom
Open
deps: add missing static linking targets for libffi#63168ShogunPanda wants to merge 3 commits intonodejs:mainfrom
ShogunPanda wants to merge 3 commits intonodejs:mainfrom
Conversation
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
ShogunPanda
added
the
ffi
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
anonrig
approved these changes
May 7, 2026
Collaborator
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63168 +/- ##
==========================================
- Coverage 90.03% 90.03% -0.01%
==========================================
Files 713 713
Lines 224510 224699 +189
Branches 42438 42478 +40
==========================================
+ Hits 202148 202310 +162
- Misses 14163 14172 +9
- Partials 8199 8217 +18 🚀 New features to boost your workflow:
|
aduh95
reviewed
May 8, 2026
Comment on lines
+33
to
+36
| Bundled libffi support is available on all Node.js supported platforms where | ||
| libffi provides a compatible static backend. Targets not supported by bundled | ||
| libffi require building Node.js against a shared libffi with `--shared-ffi`. | ||
| The unofficial GN build does not support `node:ffi`. |
Contributor
There was a problem hiding this comment.
Suggested change
| Bundled libffi support is available on all Node.js supported platforms where | |
| libffi provides a compatible static backend. Targets not supported by bundled | |
| libffi require building Node.js against a shared libffi with `--shared-ffi`. | |
| The unofficial GN build does not support `node:ffi`. | |
| Building Node.js with `node:ffi` support is available via the bundled `libffi` on | |
| platforms where `libffi` provides a compatible static backend, or via a | |
| shared `libffi` using the `--shared-ffi` configure flag. | |
| The unofficial GN build does not support `node:ffi`. |
aduh95
reviewed
May 8, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures static linking of libffi wherever it is supported.