[24.x] deps: update nghttp2 to 1.69.0#63164
Open
mcollina wants to merge 2 commits intonodejs:v24.x-stagingfrom
Open
[24.x] deps: update nghttp2 to 1.69.0#63164mcollina wants to merge 2 commits intonodejs:v24.x-stagingfrom
mcollina wants to merge 2 commits intonodejs:v24.x-stagingfrom
Conversation
PR-URL: nodejs#62891 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> (cherry picked from commit 5320a1b)
This is a set of src & tests fixes for nghttp2 due to changes in v1.67.0+ which require a selection of changes to how we handle low-level protocol errors when using the latest versions of nghttp2, changing both some src error handling and updating some tests to match. Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: nodejs#62891 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> (cherry picked from commit 4a32c00)
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
pimterry
approved these changes
May 7, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v24.x-staging #63164 +/- ##
=================================================
+ Coverage 90.06% 90.09% +0.02%
=================================================
Files 672 673 +1
Lines 201174 202293 +1119
Branches 39304 39572 +268
=================================================
+ Hits 181197 182252 +1055
- Misses 12240 12241 +1
- Partials 7737 7800 +63
🚀 New features to boost your workflow:
|
mcollina
changed the title
github-actions
Bot
removed
the
request-ci
Collaborator
Contributor
|
@nodejs/lts how confortable are we to land this on LTS release line given the test changes? |
Collaborator
Member
Author
|
We need to backport this update due to GHSA-6933-cjhr-5qg6. I assume we don't want to float a patch on top of nghttp2, which also would not please security scanners. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.