doc,sqlite: document entryPoint argument for loadExtension#63152
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 8, 2026
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>
geeksilva97
force-pushed
the
doc/sqlite-load-extension-entry-point
branch
from
f7e273a to
4e10879
Compare
cjihrig
approved these changes
May 7, 2026
geeksilva97
added
the
commit-queue
Renegade334
approved these changes
May 8, 2026
Member
There was a problem hiding this comment.
LGTM, but I notice as a drive-by:
Lines 2435 to 2437 in a9b98b2
This isn't a path argument, so I don't think this should be here? (Actually, it's currently a no-op anyway, as it only runs when the argument doesn't exist!)
Contributor
Author
Yeah, this should be removed. |
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 11740ef |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing information about entryPoint argument in
loadExtension.