Add storage description link discovery#1854
Add storage description link discovery#1854SarthakDudhe wants to merge 1 commit intonodeSolidServer:mainfrom
Conversation
There was a problem hiding this comment.
Great, thanks for doing this. I haven't run the tests but this generally looks good to me. I've run the code locally and it is referring to the expected URL for storage description resource.
Does this code assume that storage root is always at req.hostname + '/'?
I can't remember now but does NSS allow non-root path to be storage root? If so, does the code take that into account?
NSS only allow subdomain. Storage starts at root path. |
|
Ok, great. If you review / approve, we should merge this. |
|
From https://solidproject.org/TR/protocol#storage-description-statements Which is not actually the case. If this is correct it implies to
|
|
In NSS, it'd be (the slash for the storage resource):
I don't understand why a migration script is necessary (although I understand it'd be useful to do). |
|
Thanks yes you are right I have updated above. |
Add
storageDescriptionLink headers for GET, HEAD, and OPTIONS requests.Point the relation to the root storage metadata resource (
/.meta).Cover resources and containers in HTTP integration tests.
Fixes #1805.
Tests
npm run lint
npm run mocha-integration