fix: chain exceptions with from in 12 remaining raise sites#2565
Open
blackwell-systems wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: chain exceptions with from in 12 remaining raise sites#2565blackwell-systems wants to merge 1 commit intomodelcontextprotocol:mainfrom
from in 12 remaining raise sites#2565blackwell-systems wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2542. Adds
fromto 12 remainingraisestatements insideexceptblocks that discard the original exception chain.Fixes #2564
Changes
7 files, 12 sites. Each change adds
from e(orfrom exc) to an existingraiseinside anexceptblock:client/session.py:ValidationError,SchemaErrorre-raised asRuntimeErrorclient/auth/utils.py:ValidationErrorre-raised asOAuthRegistrationError,OAuthTokenErrorserver/auth/middleware/client_auth.py:ValueError/UnicodeDecodeError/binascii.Errorre-raised asAuthenticationErrorserver/mcpserver/resources/types.py: 4 sites inFunctionResource,FileResource,DirectoryResourceserver/mcpserver/resources/resource_manager.py: 1 siteserver/mcpserver/resources/templates.py: 1 siteserver/mcpserver/prompts/base.py: 2 sites (also addsas ebinding on line 184 which was missing)How Has This Been Tested?
All changes are purely additive (
fromclause) and do not alter control flow or exception types. Existing tests pass unchanged:Ruff and pyright pass with zero errors on all changed files.