Add build-changed task in Java workflow#3125
Closed
jagdish-15 wants to merge 1 commit intoexercism:mainfrom
Closed
Add build-changed task in Java workflow#3125jagdish-15 wants to merge 1 commit intoexercism:mainfrom
jagdish-15 wants to merge 1 commit intoexercism:mainfrom
Conversation
jagdish-15
changed the title
kahgoh
reviewed
May 9, 2026
| - name: Set up JDK 21 | ||
| uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 | ||
| with: | ||
| java-version: 21 |
Member
There was a problem hiding this comment.
I think we should use Java 25 (the test runner uses Java 25).
| changed_files=$(git diff --name-only "$MERGE_BASE" HEAD) | ||
|
|
||
| # If any Gradle build file changed, run the full suite and exit | ||
| if echo "$changed_files" | grep -qE '\.(gradle|gradlew|bat)$|settings\.gradle'; then |
Member
There was a problem hiding this comment.
Do we also need to also check the Gradle wrapper files (gradle-wrapper.jar and gradle-wrapper.properties)
Member
Author
There was a problem hiding this comment.
In that case, should we also add the following in the yml file:
pull_request:
paths:
- "**/*.java"
- "**/*.gradle"
- "**/gradle-wrapper.properties"
- "**/gradle-wrapper.jar"
- "**/gradlew"
- "**/gradlew.bat"
Currently it's:
pull_request:
paths:
- "**/*.java"
- "**/*.gradle"
Member
Author
There was a problem hiding this comment.
Initially, I just added this line since that is what we did for the test-changed task
Member
Author
|
Superseded by #3126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull request
Reviewer Resources:
Track Policies