Skip to content

Prevent mouse events from reaching the PTY during override#55

Merged
nedtwigg merged 2 commits intomainfrom
codex/fix-temporary-mouse-override
May 7, 2026
Merged

Prevent mouse events from reaching the PTY during override#55
nedtwigg merged 2 commits intomainfrom
codex/fix-temporary-mouse-override

Conversation

@nedtwigg
Copy link
Copy Markdown
Member

@nedtwigg nedtwigg commented May 7, 2026

nedtwigg and others added 2 commits May 7, 2026 14:16
Move the native-mouse-suppression predicate into mouse-selection so it lives
with the state it derives from, and drop the redundant per-pendingDrag
suppression snapshot in favor of calling the helper directly. Also:
- check button-mismatch before consuming the mouseup so we don't swallow
  events that aren't ours
- drop the dead temporary-override snapshot guard (the helper already
  short-circuits)
- collapse the six element listener add/remove pairs into a loop
- comment the queueMicrotask in clearTemporaryOverrideAfterMouseDispatch

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1f2101c
Status: ✅  Deploy successful!
Preview URL: https://c8e6a66c.mouseterm.pages.dev
Branch Preview URL: https://codex-fix-temporary-mouse-ov.mouseterm.pages.dev

View logs

@nedtwigg nedtwigg marked this pull request as ready for review May 7, 2026 21:29
@nedtwigg nedtwigg merged commit 7b92c93 into main May 7, 2026
6 checks passed
@nedtwigg nedtwigg deleted the codex/fix-temporary-mouse-override branch May 7, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mouse bypass should not allow clicks to go through

1 participant