fix(ci): place --no-raise before bump subcommand in bumpversion.yml#1954
Open
bearomorphism wants to merge 1 commit intocommitizen-tools:masterfrom
Open
fix(ci): place --no-raise before bump subcommand in bumpversion.yml#1954bearomorphism wants to merge 1 commit intocommitizen-tools:masterfrom
bearomorphism wants to merge 1 commit intocommitizen-tools:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1954 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 61 61
Lines 2779 2779
=======================================
Hits 2730 2730
Misses 49 49 ☔ View full report in Codecov by Sentry. |
2 tasks
The bump-version step in bumpversion.yml passed --no-raise 21 after the
`bump` subcommand, but `--no-raise` is a top-level commitizen option.
With it placed after the subcommand, argparse treats `--no-raise 21` as
unknown trailing arguments and the CLI exits with code 18
(`INVALID_COMMAND_ARGUMENT`):
Invalid commitizen arguments were found: `--no-raise`.
Please use -- separator for extra git args
This is what failed the bump workflow on master in run 25542335831.
Move the option before `bump` so it is parsed by the parent parser, as
intended by 5513e01 (`ci(bump): gracefully handle no bump-eligible
commits`).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
5f2d2bc to
a66f766
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the bump workflow that has been failing on master since #1950 was merged.
The bump step uses:
but
--no-raiseis a top-level commitizen option, so it must come before thebumpsubcommand. With it placed after, argparse treats--no-raise 21as unknown trailing arguments and the CLI exits with code 18 (INVALID_COMMAND_ARGUMENT):This is what failed run 25542335831.
Fix
Move
--no-raise 21beforebump:Verified locally:
Checklist
Was generative AI tooling used to co-author this PR?
Generated-by: GitHub Copilot