Fix: modify the logic error of EventChangedType in EtcdRepository.java #38561
Open
AsyncKurisu wants to merge 2 commits intoapache:masterfrom
Open
Fix: modify the logic error of EventChangedType in EtcdRepository.java #38561AsyncKurisu wants to merge 2 commits intoapache:masterfrom
AsyncKurisu wants to merge 2 commits intoapache:masterfrom
Conversation
…ry.java and add test functions.
Author
|
@terrymanu Can you please review this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33134
Problem Description:
The incorrect event type determined in getEventChangedType() is propagated into the DataChangedEvent object. Since subsequent metadata refresh logic relies entirely on event.getType(), the misclassified type leads to incorrect execution paths in both onChange() and handle(). As a result, a DELETE event may be processed as an ADD event, preventing the expected metadata removal and causing metadata refresh inconsistencies.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.