Update suse15 packaging spec, use qemu-ovmf-x86_64 package instead of edk2-ovmf for agent by sureshanaparti · Pull Request #13133 · apache/cloudstack

sureshanaparti · 2026-05-08T09:27:31Z

Description

This PR update suse15 packaging spec, use qemu-ovmf-x86_64 package instead of edk2-ovmf for agent.

Fixes #13004

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sureshanaparti · 2026-05-08T09:28:20Z

@blueorangutan package

blueorangutan · 2026-05-08T09:30:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2026-05-08T09:39:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.68%. Comparing base (ddcc0c8) to head (f00214d).
⚠️ Report is 1 commits behind head on 4.22.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #13133      +/-   ##
============================================
- Coverage     17.68%   17.68%   -0.01%     
+ Complexity    15794    15792       -2     
============================================
  Files          5922     5922              
  Lines        533095   533119      +24     
  Branches      65208    65201       -7     
============================================
- Hits          94281    94259      -22     
- Misses       428171   428216      +45     
- Partials      10643    10644       +1

Flag	Coverage Δ
uitests	`3.69% <ø> (ø)`
unittests	`18.75% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache · 2026-05-08T09:47:38Z

@sureshanaparti
can we just update e8/cloud.spec instead of creating a new one ?

diff --git a/packaging/el8/cloud.spec b/packaging/el8/cloud.spec
index 3dee161bf27..13c0a36cb10 100644
--- a/packaging/el8/cloud.spec
+++ b/packaging/el8/cloud.spec
@@ -117,7 +117,7 @@ Requires: ipset
 Requires: perl
 Requires: rsync
 Requires: cifs-utils
-Requires: edk2-ovmf
+Requires: (edk2-ovmf or qemu-ovmf-x86_64)
 Requires: swtpm
 Requires: (python3-libvirt or python3-libvirt-python)
 Requires: (qemu-img or qemu-tools)

sureshanaparti · 2026-05-08T10:29:25Z

@sureshanaparti can we just update e8/cloud.spec instead of creating a new one ?

diff --git a/packaging/el8/cloud.spec b/packaging/el8/cloud.spec
index 3dee161bf27..13c0a36cb10 100644
--- a/packaging/el8/cloud.spec
+++ b/packaging/el8/cloud.spec
@@ -117,7 +117,7 @@ Requires: ipset
 Requires: perl
 Requires: rsync
 Requires: cifs-utils
-Requires: edk2-ovmf
+Requires: (edk2-ovmf or qemu-ovmf-x86_64)
 Requires: swtpm
 Requires: (python3-libvirt or python3-libvirt-python)
 Requires: (qemu-img or qemu-tools)

ok @weizhouapache , let me check

sureshanaparti · 2026-05-08T10:32:00Z

@weizhouapache is it good to have separate spec for suse? otherwise, we've to keep the updating el8 spec for suse variants with 'or'?

blueorangutan · 2026-05-08T10:35:00Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17782

This reverts commit d20b095.

This reverts commit 617ff60.

sureshanaparti · 2026-05-08T11:28:28Z

@weizhouapache updated as advised, please check. thanks.

sureshanaparti · 2026-05-08T11:28:36Z

@blueorangutan package

blueorangutan · 2026-05-08T11:30:05Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache

code lgtm

did not test it

blueorangutan · 2026-05-08T12:27:53Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17783

weizhouapache · 2026-05-08T12:49:13Z

@blueorangutan test suse15 kvm-suse15

blueorangutan · 2026-05-08T12:50:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (suse15 mgmt + kvm-suse15) has been kicked to run smoke tests

blueorangutan · 2026-05-09T04:21:50Z

[SF] Trillian test result (tid-16056)
Environment: kvm-suse15 (x2), zone: Advanced Networking with Mgmt server s15
Total time taken: 53629 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13133-t16056-kvm-suse15.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deploy_vm_from_iso_uefi_secure	`Error`	54.61	test_deploy_vm_iso_uefi.py
test_02_deploy_vm_from_iso_uefi_legacy	`Error`	12.63	test_deploy_vm_iso_uefi.py
test_03_deploy_windows_vm_from_iso_uefi_legacy	`Error`	11.53	test_deploy_vm_iso_uefi.py
test_04_deploy_windows_vm_from_iso_uefi_secure	`Error`	12.56	test_deploy_vm_iso_uefi.py

rajujith

LGTM
Tested.
The error ' nothing provides 'edk2-ovmf' is not seens anymore for cloudstack-agent installation on openSUSE 15.6

weizhouapache · 2026-05-10T17:43:20Z

[SF] Trillian test result (tid-16056) Environment: kvm-suse15 (x2), zone: Advanced Networking with Mgmt server s15 Total time taken: 53629 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13133-t16056-kvm-suse15.zip Smoke tests completed. 148 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_deploy_vm_from_iso_uefi_secure Error 54.61 test_deploy_vm_iso_uefi.py
test_02_deploy_vm_from_iso_uefi_legacy Error 12.63 test_deploy_vm_iso_uefi.py
test_03_deploy_windows_vm_from_iso_uefi_legacy Error 11.53 test_deploy_vm_iso_uefi.py
test_04_deploy_windows_vm_from_iso_uefi_secure Error 12.56 test_deploy_vm_iso_uefi.py

@sureshanaparti
could you check these test failures ?

…ferent for suse15)

sureshanaparti · 2026-05-10T20:29:23Z

[SF] Trillian test result (tid-16056) Environment: kvm-suse15 (x2), zone: Advanced Networking with Mgmt server s15 Total time taken: 53629 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13133-t16056-kvm-suse15.zip Smoke tests completed. 148 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
Test Result Time (s) Test File
test_01_deploy_vm_from_iso_uefi_secure Error 54.61 test_deploy_vm_iso_uefi.py
test_02_deploy_vm_from_iso_uefi_legacy Error 12.63 test_deploy_vm_iso_uefi.py
test_03_deploy_windows_vm_from_iso_uefi_legacy Error 11.53 test_deploy_vm_iso_uefi.py
test_04_deploy_windows_vm_from_iso_uefi_secure Error 12.56 test_deploy_vm_iso_uefi.py

@sureshanaparti could you check these test failures ?

@weizhouapache Noticed errors - "Failed to open file '/usr/share/edk2/ovmf/OVMF_VARS.secboot.fd", "Failed to open file '/usr/share/edk2/ovmf/OVMF_VARS.fd"

It seems the UEFI files are now different for suse (https://documentation.suse.com/sles/15-SP6/html/SLES-all/cha-kvm-inst.html#cha-kvm-inst-virtman-advanced-uefi). I've updated the new UEFI files in a separate properties file for suse.

/usr/share/edk2/ovmf/OVMF_VARS.fd -> /usr/share/qemu/ovmf-x86_64-vars.bin
/usr/share/edk2/ovmf/OVMF_CODE.cc.fd -> /usr/share/qemu/ovmf-x86_64-code.bin
/usr/share/edk2/ovmf/OVMF_VARS.secboot.fd -> /usr/share/qemu/ovmf-x86_64-ms-vars.bin
/usr/share/edk2/ovmf/OVMF_CODE.secboot.fd -> /usr/share/qemu/ovmf-x86_64-ms-code.bin

sureshanaparti · 2026-05-10T20:29:43Z

@blueorangutan package

blueorangutan · 2026-05-10T20:30:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-10T21:27:26Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17804

sureshanaparti · 2026-05-10T21:29:44Z

@blueorangutan test suse15 kvm-suse15

blueorangutan · 2026-05-10T21:32:04Z

@sureshanaparti a [SL] Trillian-Jenkins test job (suse15 mgmt + kvm-suse15) has been kicked to run smoke tests

sureshanaparti added 2 commits May 8, 2026 14:51

Maintain separate packaging spec for suse15

617ff60

Update qemu-ovmf-x86_64 package instead of edk2-ovmf for agent

d20b095

boring-cyborg Bot added the component:packaging label May 8, 2026

sureshanaparti requested review from DaanHoogland and rajujith May 8, 2026 09:30

sureshanaparti linked an issue May 8, 2026 that may be closed by this pull request

edk2-ovmf added as dependency for cloudstack-agent is not available on openSuse #13004

Open

sureshanaparti added this to the 4.22.1 milestone May 8, 2026

sureshanaparti added 3 commits May 8, 2026 16:54

Revert "Update qemu-ovmf-x86_64 package instead of edk2-ovmf for agent"

323149e

This reverts commit d20b095.

Revert "Maintain separate packaging spec for suse15"

87ba3d4

This reverts commit 617ff60.

Update qemu-ovmf-x86_64 package in agent for suse

118bb20

sureshanaparti requested a review from weizhouapache May 8, 2026 11:39

weizhouapache approved these changes May 8, 2026

View reviewed changes

sureshanaparti added this to Apache CloudStack 4.22.1 May 8, 2026

github-project-automation Bot moved this to Todo in Apache CloudStack 4.22.1 May 8, 2026

sureshanaparti moved this from Todo to In Progress in Apache CloudStack 4.22.1 May 8, 2026

rajujith approved these changes May 10, 2026

View reviewed changes

Maintain separate properties file for suse15 (UEFI properties are dif…

f00214d

…ferent for suse15)

Conversation

sureshanaparti commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented May 8, 2026

Uh oh!

blueorangutan commented May 8, 2026

Uh oh!

codecov Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache commented May 8, 2026

Uh oh!

sureshanaparti commented May 8, 2026

Uh oh!

sureshanaparti commented May 8, 2026

Uh oh!

blueorangutan commented May 8, 2026

Uh oh!

sureshanaparti commented May 8, 2026

Uh oh!

sureshanaparti commented May 8, 2026

Uh oh!

blueorangutan commented May 8, 2026

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented May 8, 2026

Uh oh!

weizhouapache commented May 8, 2026

Uh oh!

blueorangutan commented May 8, 2026

Uh oh!

blueorangutan commented May 9, 2026

Uh oh!

rajujith left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented May 10, 2026

Uh oh!

sureshanaparti commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sureshanaparti commented May 10, 2026

Uh oh!

blueorangutan commented May 10, 2026

Uh oh!

blueorangutan commented May 10, 2026

Uh oh!

sureshanaparti commented May 10, 2026

Uh oh!

blueorangutan commented May 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sureshanaparti commented May 8, 2026 •

edited

Loading

codecov Bot commented May 8, 2026 •

edited

Loading

sureshanaparti commented May 10, 2026 •

edited

Loading