refactor(@angular-devkit/architect): use custom indent logger #33152
Open
clydin wants to merge 2 commits intoangular:mainfrom
Open
refactor(@angular-devkit/architect): use custom indent logger #33152clydin wants to merge 2 commits intoangular:mainfrom
clydin wants to merge 2 commits intoangular:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the use of createConsoleLogger with logging.IndentLogger in both the architect and schematics CLIs. The logging logic is now manually handled via subscriptions, allowing for more direct control over output streams and styling. Additionally, the schematics CLI tests were updated to use PassThrough streams and stripVTControlCharacters for more robust output verification. I have no feedback to provide.
clydin
force-pushed
the
refactor/custom-logging
branch
2 times, most recently
from
e631835 to
ae361e7
Compare
Replaces `createConsoleLogger` with a custom `logging.IndentLogger` implementation to remove dependency on `@angular-devkit/core/node` helper.
…d improve tests Replaces `createConsoleLogger` with a custom `logging.IndentLogger` implementation that respects custom output streams. Also refactors tests to use standard `PassThrough` streams and `stripVTControlCharacters` instead of custom mocks.
clydin
force-pushed
the
refactor/custom-logging
branch
from
ae361e7 to
4334bd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
createConsoleLoggerwith a customlogging.IndentLoggerimplementation to remove dependency on@angular-devkit/core/nodehelper.