fix: add explicit encoding to open() calls for cross-platform portability#14658
Closed
KeloYuan wants to merge 1 commit intoTheAlgorithms:masterfrom
Closed
fix: add explicit encoding to open() calls for cross-platform portability#14658KeloYuan wants to merge 1 commit intoTheAlgorithms:masterfrom
KeloYuan wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
…lity Python's open() uses locale-dependent encoding by default, which varies across platforms (UTF-8 on macOS/Linux, cp1252 on Windows). This causes files to be read/written incorrectly on some systems. Added encoding='utf-8' to all text-mode open() calls in: - searches/tabu_search.py - data_structures/arrays/sudoku_solver.py - strings/word_patterns.py - data_compression/huffman.py - strings/detecting_english_programmatically.py
Closing this pull request as invalid@KeloYuan, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines. If you're facing any problem on how to mark a checkbox, please read the following instructions:
NOTE: Only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Python's
open()uses locale-dependent encoding by default, which varies across platforms:This means code that works perfectly on macOS/Linux can silently corrupt data on Windows (and vice versa). Since Python 3.15, the default will change to UTF-8, but for now it's best practice to be explicit.
PEP 686 (Python 3.15+) will make UTF-8 the default, but explicit encoding is recommended for all current Python versions.
Changes
Added
encoding="utf-8"to text-modeopen()calls in 5 files:searches/tabu_search.pydata_structures/arrays/sudoku_solver.pystrings/word_patterns.pydata_compression/huffman.pystrings/detecting_english_programmatically.pyTesting
All existing tests pass — no behavioral change for correct UTF-8 files.