Skip to content

fix(ios): Fix check for dynamic lib #6032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PeterStaev wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −11
Open

fix(ios): Fix check for dynamic lib #6032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions lib/services/ios-project-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,12 +500,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
}

private async isDynamicFramework(frameworkPath: string): Promise<boolean> {
const isDynamicFrameworkBundle = async (
bundlePath: string,
frameworkName: string,
) => {
const frameworkBinaryPath = path.join(bundlePath, frameworkName);

const isDynamicFrameworkBundle = async (frameworkBinaryPath: string) => {
const fileResult = (
await this.$childProcess.spawnFromEvent(
"file",
Expand Down Expand Up @@ -533,10 +528,15 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
singlePlatformFramework,
path.extname(singlePlatformFramework),
);
isDynamic = await isDynamicFrameworkBundle(
singlePlatformFramework,
frameworkName,
);
let frameworkBinaryPath = path.join(singlePlatformFramework, frameworkName)
if (library.BinaryPath) {
frameworkBinaryPath = path.join(
frameworkPath,
library.LibraryIdentifier,
library.BinaryPath,
);
}
isDynamic = await isDynamicFrameworkBundle(frameworkBinaryPath);
break;
}
}
Expand All @@ -546,7 +546,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
frameworkPath,
path.extname(frameworkPath),
);
return await isDynamicFrameworkBundle(frameworkPath, frameworkName);
return await isDynamicFrameworkBundle(path.join(frameworkPath, frameworkName));
}
}

Expand Down
Loading