fix(docker): add SELinux labeling to bind mounts#1291
Open
derekwaynecarr wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix(docker): add SELinux labeling to bind mounts#1291derekwaynecarr wants to merge 1 commit intoNVIDIA:mainfrom
derekwaynecarr wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Switch from Docker Mount API to string-based binds API with :z labels to enable SELinux-enforcing systems to access bind-mounted files. The :z option applies a shared SELinux content label, allowing containers to read supervisor binaries and TLS certificates. Docker safely ignores :z on non-SELinux systems. Signed-off-by: Derek Carr <decarr@redhat.com>
derekwaynecarr
requested review from
a team,
maxamillion and
mrunalp
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch from Docker Mount API to string-based binds API with :z labels to enable SELinux-enforcing systems to access bind-mounted files.
The :z option applies a shared SELinux content label, allowing containers to read supervisor binaries and TLS certificates. Docker safely ignores :z on non-SELinux systems.
Related Issue
Changes
Testing
mise run pre-commitpassesChecklist