Conversation
Closes #1266 Install RPM release payloads into user-local paths on ostree hosts so immutable deployments do not require package layering or reboot before starting the gateway service. Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
|
🌿 Preview your docs: https://nvidia-preview-pr-1285.docs.buildwithfern.com/openshell |
| fi | ||
| } | ||
|
|
||
| install_ostree_payload_files() { |
There was a problem hiding this comment.
I'd like to suggest this reused the user unit that's in the rpm payload instead of maintaining the unit in multiple places unless there is a compelling reason otherwise.
There was a problem hiding this comment.
Agree. I pushed another change to reuse the rpm unit payload. It still seems like there are too many changes to the install script here to support this. I am not very familiar ostree or rpm. Is there a better approach we can take here that doesn't require adding another rpm-ostree path?
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Stage the systemd user unit from the extracted RPM payload and patch only the user-local relocation and local gateway port fields. Remove the standalone installer shell test script and task hook. Signed-off-by: Drew Newberry <anewberry@nvidia.com>
| rpm) | ||
| install_linux_rpm | ||
| ;; | ||
| rpm-ostree) |
There was a problem hiding this comment.
Might be better to refer to it as a bootc system... rpm-ostree is kinda the older version of bootc (loosely)...
3 participants
Summary
Adds an ostree-specific install path in
install.shfor RPM-based immutable hosts. The installer downloads and verifies RPM assets, extracts payloads into user-local paths, stages the systemd user unit from the RPM payload with only relocation/local-port adjustments, and starts/registers the local gateway without mutating/usror requiring reboot.Related Issue
Closes #1266
Changes
install.sh: detect ostree RPM hosts, extract RPM payloads locally, stage CLI/gateway/helper files, reuse the packaged RPM user unit with user-local path adjustments, and reuse gateway startup.docs/about/installation.mdx,docs/get-started/quickstart.mdx: document ostree user-local install behavior.Deviations from Plan
Implemented in
install.shbecauseinstall-dev.shwas renamed before this work. Per review feedback, the ostree path now reuses the RPM payload user unit instead of generating a separate unit body in the installer.Testing
mise run pre-commitpassesTests added:
Checklist
Documentation updated:
docs/about/installation.mdxdocs/get-started/quickstart.mdx