satellite-tracker 0.1.20 (new formula)#281538
satellite-tracker 0.1.20 (new formula)#281538jaxvanyang wants to merge 1 commit intoHomebrew:mainfrom
Conversation
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
|
The rename should not be removed. If you want to submit this, you can name it |
Thank you for your suggestion, didn't know that I could prefix the author's name. I'll rename the package and revert the deletion. Before that, I want to ask the author if he/she wants another name @ShenMian. And I'm trying to fix the CI. |
|
@jaxvanyang Thank you for your work. I think a more semantic name like By the way, why is the version number |
| end | ||
|
|
||
| test do | ||
| system bin/"tracker", "--version" |
There was a problem hiding this comment.
We need a test that exercises the some of the functionality of the app. Version checks or usage checks (foo --version or foo --help) are not sufficient, as explained in the formula cookbook.
In most cases, a good test would involve running a simple test case: run #{bin}/foo input.txt.
- Then you can check that the output is as expected (with assert_equal or assert_match on the output of shell_output)
- You can also check that an output file was created, if that is expected: assert_predicate testpath/"output.txt", :exist?
Some advice for specific cases:
- If the formula is a library, compile and run some simple code that links against it. It could be taken from upstream's documentation / source examples.
- If the formula is for a GUI program, try to find some function that runs as command-line only, like a format conversion, reading or displaying a config file, etc.
- If the software cannot function without credentials, a test could be to try to connect with invalid credentials (or without credentials) and confirm that it fails as expected.
- Same if the software requires a virtual machine, docker instance, etc. to be running.
There was a problem hiding this comment.
Sorry for that I didn't mention this in the comment. This is a TUI application, its usage is just:
Usage: tracker
Options:
-h, --help Print help
-V, --version Print version
So I can only run this command-line only function. I know this is a bad test, but the doc also says bad test is better than no test.
9385b4a to
f8999a9
Compare
Oops, I made a typo on the version number, I'll fix that. I agree with you, the name can make users more clear. |
f8999a9 to
26c1a9f
Compare
Also deleted an old rename entry due to conflict. I think it's safe to do so because the former
trackerseems to be a part oftinysparql, most of people may just installtinysparqlif them want it.Refs: ShenMian/tracker#26
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?brew test <formula>?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?